git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: use "quick" has_sha1_file for tag following

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 14, 2016, 17:39 UTC
Message-ID
<xmqqfunyzv6f.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20161013200644.lnustevmpvufbg5y@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> So it's certainly better. But 7500 packs is just silly, and squeezing
> out ~400ms there is hardly worth it. If you repack this same case into a
> single pack, the command drops to 5ms. So yes, there's close to an order
> of magnitude speedup here, but you get that _and_ another order of
> magnitude just by repacking.

"7500 is silly" equally applies to the "quick" (and sloppy, if I am reading your "Failing in this direction doesn't make me feel great." correctly) approach, I think, which argues for not taking either change X-<.

I agree that the fallout from the inaccuracy of "quick" approach is probably acceptable and the next "fetch" will correct it anyway, so let's do the "quick but inaccurate" for now and perhaps cook it in 'next' for a bit longer than other topics?

Previous: Jeff KingNext: Jeff King
Message 13 of 22 in “Huge performance bottleneck reading packs”
  1. Vegard NossumOct 12, 2016
  2. Junio C HamanoOct 12, 2016
  3. Vegard NossumOct 13, 2016
  4. Jeff KingOct 13, 2016
  5. Jeff KingOct 12, 2016
  6. Jeff KingOct 12, 2016
  7. Jeff KingOct 12, 2016
  8. Vegard NossumOct 13, 2016
  9. Jeff KingOct 13, 2016
  10. fetch: use "quick" has_sha1_file for tag followingJeff King, Oct 13, 2016
  11. Jeff KingOct 13, 2016
  12. Jeff KingOct 13, 2016
  13. Junio C HamanoOct 14, 2016
  14. Jeff KingOct 14, 2016
  15. Junio C HamanoOct 17, 2016
  16. Jeff KingOct 18, 2016
  17. Vegard NossumOct 13, 2016
  18. Jeff KingOct 13, 2016
  19. Vegard NossumOct 14, 2016
  20. Jeff KingOct 14, 2016
  21. Jakub NarębskiOct 14, 2016
  22. Vegard NossumOct 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.