Re: [PATCH] docs: warn about possible '=' in clean/smudge filter process values

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2016, 17:49 UTC
Message-ID: <xmqqfum25kr0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161205131219.kdq4zafith26vro2@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> On Sat, Dec 03, 2016 at 08:45:16PM +0100, larsxschneider@gmail.com wrote:
>
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> A pathname value in a clean/smudge filter process "key=value" pair can
>> contain the '=' character (introduced in edcc858). Make the user aware
>> of this issue in the docs, add a corresponding test case, and fix the
>> issue in filter process value parser of the example implementation in
>> contrib.
>
> Yeah, I just naturally assumed it would work this way, as it's pretty
> standard in our other key=value protocols. But certainly it's reasonable
> to document it (and to keep the t0021 filter as a good example).

There are diplomatic ways and other ways to say the same thing, it seems, and yours is almost always more diplomatic than mine ;-)

My knee-jerk reaction last night that I didn't send was "I would understand if the new test were about quotes or whitespaces, but is it even useful to make sure that the value can have an equal sign in it?"