Re: [PATCH v4 2/5] name-rev: extend --refs to accept multiple patterns
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 19, 2017, 21:06 UTC
- Message-ID
- <xmqqfukezrmh.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170118230608.28030-3-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 14 quoted lines
> From: Jacob Keller <jacob.keller@gmail.com> > > Teach git name-rev to take multiple --refs stored as a string list of > patterns. The list of patterns will be matched inclusively, and each ref > only needs to match one pattern to be included. A ref will only be > excluded if it does not match any of the given patterns. Additionally, > if any of the patterns would allow abbreviation, then we will abbreviate > the ref, even if another pattern is more strict and would not have > allowed abbreviation on its own. > > Add tests and documentation for this change. The tests expected output > is dynamically generated, but this is in order to avoid hard-coding > a commit object id in the test results (as the expected output is to > simply leave the commit object unnamed).
Makes sense.
I do not see anything that requires "... generated, but" there, though, as if it is a bad thing to do to prepare expected output dynamically. I'd just reword "generated. This is..." to make it neutral.