git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/5] name-rev: extend --refs to accept multiple patterns

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 19, 2017, 21:06 UTC
Message-ID
<xmqqfukezrmh.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170118230608.28030-3-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 14 quoted lines
> From: Jacob Keller <jacob.keller@gmail.com>
>
> Teach git name-rev to take multiple --refs stored as a string list of
> patterns. The list of patterns will be matched inclusively, and each ref
> only needs to match one pattern to be included. A ref will only be
> excluded if it does not match any of the given patterns. Additionally,
> if any of the patterns would allow abbreviation, then we will abbreviate
> the ref, even if another pattern is more strict and would not have
> allowed abbreviation on its own.
>
> Add tests and documentation for this change. The tests expected output
> is dynamically generated, but this is in order to avoid hard-coding
> a commit object id in the test results (as the expected output is to
> simply leave the commit object unnamed).
Makes sense.  

I do not see anything that requires "... generated, but" there, though, as if it is a bad thing to do to prepare expected output dynamically. I'd just reword "generated. This is..." to make it neutral.

Previous: Junio C HamanoNext: Jacob Keller
Message 8 of 11 in “extend git-describe pattern matching”
  1. 0/5 extend git-describe pattern matchingJacob Keller, Jan 18, 2017
  2. 5/5 describe: teach describe negative pattern matchesJacob Keller, Jan 18, 2017
  3. 4/5 describe: teach --match to accept multiple patternsJacob Keller, Jan 18, 2017
  4. 3/5 name-rev: add support to exclude refs by pattern matchJacob Keller, Jan 18, 2017
  5. Junio C HamanoJan 19, 2017
  6. 2/5 name-rev: extend --refs to accept multiple patternsJacob Keller, Jan 18, 2017
  7. Junio C HamanoJan 19, 2017
  8. Junio C HamanoJan 19, 2017
  9. Jacob KellerJan 19, 2017
  10. Jacob KellerJan 19, 2017
  11. 1/5 doc: add documentation for OPT_STRING_LISTJacob Keller, Jan 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.