Re: [PATCH v4 0/5] urlmatch: allow wildcard-based matches

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2017, 22:52 UTC
Message-ID: <xmqqfuk0tb3j.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqy3xstdh9.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Patrick Steinhardt <patrick.steinhardt@elego.de> writes:
>
>>  - I realized that with my patches, "ranking" of URLs was broken.
>>    Previously, we've always taken the longest matching URL. As
>>    previously, only the user and path could actually differ, only
>>    these two components were used for the comparison. I've
>>    changed this now to also include the host part so that URLs
>>    with a longer host will take precedence. This resulted in a
>>    the patch 4.
>
> Good thinking.  I was wondering about this, too.
>
> Thanks.  Will read it through and replace.

Ugh. When applied on top of 4e59582ff7 ("Seventh batch for 2.12", 2017-01-23), Git fails its self-test in t5551 #31 (I do not run with EXPENSIVE so some tests liks #30 are skipped, if it matters).