Re: [PATCH] completion: restore removed line continuating backslash

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2017, 20:45 UTC
Message-ID: <xmqqfujhddl2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170213192036.10671-1-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 10 quoted lines

> Recent commit 1cd23e9e0 (completion: don't use __gitdir() for git
> commands, 2017-02-03) rewrapped a couple of long lines, and while
> doing so it inadvertently removed a '\' from the end of a line, thus
> breaking completion for 'git config remote.name.push <TAB>'.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
>
> I wanted this to be a fixup!, but then noticed that this series is
> already in next, hence the proper commit message.

We get "--format=... : command not found"? Thanks for a set of sharp eyes.

> I see the last What's cooking marks this series as "will merge to
> master".  That doesn't mean that it will be in v2.12, does it?

I actually was hoping that these can go in. Others that can (or should) wait are marked as "Will cook in 'next'".

If you feel uncomfortable and want these to cook longer, please tell me so.

Thanks.

Show 16 quoted lines

>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 993085af6..f2b294aac 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2086,7 +2086,7 @@ _git_config ()
>  	remote.*.push)
>  		local remote="${prev#remote.}"
>  		remote="${remote%.push}"
> -		__gitcomp_nl "$(__git for-each-ref
> +		__gitcomp_nl "$(__git for-each-ref \
>  			--format='%(refname):%(refname)' refs/heads)"
>  		return
>  		;;