Re: [PATCH v2] config: reject invalid VAR in 'git -c VAR=VAL command'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 22, 2017, 01:06 UTC
- Message-ID
- <xmqqfuj7dofx.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqd1ebfd9l.fsf_-_@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
> /* find the last dot (we start from the first dot we just found) */ > - for (last_dot = cp; *cp; cp++) > + for (; *cp; cp++) > if (*cp == '.') > last_dot = cp;
This line probably needs this fix-up on top.
-- >8 -- Subject: [PATCH] config: squelch stupid compiler warnings
Some compilers do not realize that *cp is always '.' when the loop to find the last dot begins, and instead gives a useless warning that says last_dot may be uninitialized.
Squelch it by being a bit more explicit if stupid.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config.c b/config.c index e7f7ff1938..90de27853f 100644 --- a/config.c +++ b/config.c @@ -239,7 +239,7 @@ static int canonicalize_config_variable_name(char *varname) return -1; /* no section? */ /* find the last dot (we start from the first dot we just found) */ - for (; *cp; cp++) + for (last_dot = cp; *cp; cp++) if (*cp == '.') last_dot = cp;
-- 2.12.0-rc2-231-g83a1c8597c