git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: bisect-helper: we do not bisect --objects

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 6, 2017, 20:21 UTC
Message-ID
<xmqqfuiqnokp.fsf@junio-linux.mtv.corp.google.com>
In-Reply-To
<CAP8UFD0tzH+QiNM2BMhe9qcKdD0rP9T=Ry94=EPV+=d+7cdLfQ@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 5 quoted lines
> I think I just copy pasted the code from cmd_rev_list() in
> builtin-rev-list.c and probably didn't realize that revs->tree_objects
> would always be false.
>
> Thanks for spotting this and removing the dead code.

Thanks for a quick confirmation. Just FYI I was looking at this code because I was trying to assess how involved it would be to teach the code to do a bisection only on the first-parent chain.

Previous: Christian CouderNext: Philip Oakley
Message 3 of 7 in “bisect-helper: we do not bisect --objects”
  1. Junio C HamanoMar 3, 2017
  2. Christian CouderMar 3, 2017
  3. Junio C HamanoMar 6, 2017
  4. Philip OakleyMar 3, 2017
  5. Junio C HamanoMar 3, 2017
  6. Philip OakleyMar 5, 2017
  7. Junio C HamanoMar 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.