Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2017, 03:59 UTC
Message-ID: <xmqqfug6wz0s.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170513015726.20281-1-zxq_yx_007@163.com>

xiaoqiang zhao <zxq_yx_007@163.com> writes:

Show 10 quoted lines

> Some email servers (e.g. smtp.163.com) limit the number emails to be
> sent per session(connection) and this will lead to a faliure when
> sending many messages.
>
> Teach send-email to disconnect after sending a number of messages
> (configurable via the --batch-size=<num> option), wait for a few
> seconds (configurable via the --relogin-delay=<seconds> option) and
> reconnect, to work around such a limit.
>
> Also add this two configure option for git config command.

s/configure/configuration/; "for git config command" is better left unsaid (too obvious).

Show 5 quoted lines

> Note:
>    Re-authentication will happen every $<batch-size> messages, so it
> will be much more acceptable if you use some form of credential helper
> (e.g. the 'sendemail.smtppass' config option), otherwise you will have
> to retype password every time when asked.

I think this deserves to be in the end-user documentation (i.e. the part of your patch that updates Documentation/git-send-email.txt).

Other than that, looking good ;-)

Thanks.

Show 5 quoted lines

> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  contrib/completion/git-completion.bash |  2 ++
>  git-send-email.perl                    | 18 ++++++++++++++++++
>  2 files changed, 20 insertions(+)