Re: [PATCH 1/4] Doc/config.txt: explain repeated sections

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 8, 2017, 23:03 UTC
Message-ID: <xmqqfue6a5va.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170708203413.16442-2-astian@eclipso.at>

astian <astian@eclipso.at> writes:

Show 23 quoted lines

> Add a paragraph explaining what happens when a section name is repeated
> in the configuration file(s).
>
> The example configuration file shown in this document already implied
> Git's behaviour, this patch simply tries to make it explicit.
>
> Signed-off-by: astian <astian@eclipso.at>
> ---
>  Documentation/config.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index d5c9c4cab..afce25705 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -31,6 +31,10 @@ characters, `-` and `.` are allowed in section names.  Each variable
>  must belong to some section, which means that there must be a section
>  header before the first setting of a variable.
>  
> +Multiple occurrences of the same section are all logically merged.  (There's
> +no special treatment for variables defined multiple times across physically
> +different sections, the variable is simply made multivalued.)
> +

Looks correct; it's a bit surprising that we didn't already mention multiple occurrences, but I do not find it so this is a good addition.

I do not see a strong reason for () around the second sentence, though.

By the way, with something that is supposed to hopefully have some legal value down the line if somebody starts making noises, it really would be nice to have a real person to associate things with. It would be embarrassing later if there is no way to even look you up somehow. Documentation/SubmittingPatches asks you to sign-off with a real name for a reason.

Thanks.