git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug - Status - Space in Filename

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 10, 2017, 18:13 UTC
Message-ID
<xmqqfu9mf1e5.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171110095808.igydpwweyceu6qcf@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> Are there callers who don't just print the result? If not, we could just
> always emit. That's slightly more efficient since it drops the expensive
> strbuf_insert (though there are already so many copies going on in
> quote_path_relative that it hardly matters). But it also drops the need
> for the caller to know about the strbuf at all.

I am fine by that, too. Consider that I'm still suffering from the trauma caused by some patches (not in this area but others) that changed output we have long been directly emiting to stdio to instead capture to strings ;-)

This might also be a good bite-sized material for the weekend thing ;-)

Previous: Jeff King
Message 6 of 6 in “RE: Bug - Status - Space in Filename”
  1. Joseph StraussNov 8, 2017
  2. Junio C HamanoNov 9, 2017
  3. Jeff KingNov 9, 2017
  4. Junio C HamanoNov 10, 2017
  5. Jeff KingNov 10, 2017
  6. Junio C HamanoNov 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.