Re: [RFC PATCH 0/1] builtin/remote: quote remote name on error to display empty name

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 12, 2018, 16:20 UTC
Message-ID: <xmqqftyen0w8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180912144504.7498-1-m.shulhan@gmail.com>

Shulhan <m.shulhan@gmail.com> writes:

Show 11 quoted lines

> Rationale: consistent error format
>
> When adding new remote name with empty string, git will print the
> following error message,
>
>   fatal: '' is not a valid remote name\n
>
> But when removing remote name with empty string as input, git did not
> print the empty string with quote,
>
>   fatal: No such remote: \n

Thanks for noticing. I think the consistency given by the patch 1/1 is good.

> Follow up question: If this is ok, should the po files also updated?

They should be updated, but not by you and not as part of this change. The po files will be updated by our l10n coordinator, typically when it gets close to the release time, for all the message changes done during the release cycle.

Thanks.