Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 10, 2018, 23:40 UTC
- Message-ID
- <xmqqftxdjrph.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <7c08fd68-9a0a-ab2a-0667-f51726fa691b@umanovskis.se>
Daniels Umanovskis <daniels@umanovskis.se> writes:
Show 8 quoted lines
> On 10/11/18 12:26 AM, Junio C Hamano wrote: >> Among the remaining ones in the list, cherry and get-tar-commit-id >> are probably better classified as plumbing. I do not know why >> cherry is marked for completion; perhaps some crazy people use that >> on the command line? > > I think cherry could go either way, get-tar-commit-id is definitely > plumbing. Would you like me to fix those two on the same patch then?
No, what you sent for rev-parse is already good. A separate patch that addresses other ones can be discussed as an orthogonal matter. It even may deserve to make them two separate patches, as I anticipate that some people would resist marking "cherry" as plumbing, so that only one can be applied while dropping the other as/if needed.
Thanks.