Re: [PATCH v2 2/2] tests: introduce --stress-jobs=<N>
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 4, 2019, 03:22 UTC
- Message-ID
- <xmqqfts3z5kw.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAPig+cS1URdnRb0RM0HYQhtmXWn5knx6Ee1Y96Gc9dt_9LmRKA@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 17 quoted lines
> On Sun, Mar 3, 2019 at 9:45 AM Johannes Schindelin via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> [...] >> Let's introduce a separate option for that, whose name makes it more >> obvious what it is about, and let --stress=<N> error out with a helpful >> suggestion about the two options tha could possibly have been meant. >> >> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> >> --- >> diff --git a/t/README b/t/README >> @@ -187,11 +187,10 @@ appropriately before running "make". >> variable to "1" or "0", respectively. >> >> --stress:: >> ---stress=<N>:: > > Shouldn't the "--stress=<N>" line be removed?
Eyes can easily be tricked by the patch format, but the above hunk does remove that line ;-) I had the same reaction when I saw your message for the first time (before seeing the patch itself).
Show 8 quoted lines
> >> Run the test script repeatedly in multiple parallel jobs until >> one of them fails. Useful for reproducing rare failures in >> flaky tests. The number of parallel jobs is, in order of >> - precedence: <N>, or the value of the GIT_TEST_STRESS_LOAD >> + precedence: the value of the GIT_TEST_STRESS_LOAD >> environment variable, or twice the number of available >> processors (as shown by the 'getconf' utility), or 8.