git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/perf: rename duplicate-numbered test script

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 12, 2019, 16:04 UTC
Message-ID
<xmqqftm6bca3.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190812155803.GA25161@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> There are two perf scripts numbered p5600, but with otherwise different
> names ("clone-reference" versus "partial-clone"). We store timing
> results in files named after the whole script, so internally we don't
> get confused between the two. But "aggregate.perl" just prints the test
> number for each result, giving multiple entries for "5600.3". It also
> makes it impossible to skip one test but not the other with
> GIT_SKIP_TESTS.
>
> Let's renumber the one that appeared later (by date -- the source of the
> problem is that the two were developed on independent branches). For the
> non-perf test suite, our test-lint rule would have complained about this
> when the two were merged, but t/perf never learned that trick.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This is meant for 2.23, but obviously it's not hurting anything if it
> doesn't make the cut. I double-checked that there is no conflict with
> anything on pu, either. :)
Thanks for being careful.  Will apply.
Show 8 quoted lines
>  t/perf/{p5600-clone-reference.sh => p5601-clone-reference.sh} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename t/perf/{p5600-clone-reference.sh => p5601-clone-reference.sh} (100%)
>
> diff --git a/t/perf/p5600-clone-reference.sh b/t/perf/p5601-clone-reference.sh
> similarity index 100%
> rename from t/perf/p5600-clone-reference.sh
> rename to t/perf/p5601-clone-reference.sh

By the way, do we feel differently (e.g. more risky) when we see 100% rename without the "index old-oid..new-oid mode" lines and when we see 99% rename with one, with a one-line change?

Previous: Jeff KingNext: Jeff King
Message 2 of 3 in “t/perf: rename duplicate-numbered test script”
  1. t/perf: rename duplicate-numbered test scriptJeff King, Aug 12, 2019
  2. Junio C HamanoAug 12, 2019
  3. Jeff KingAug 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.