git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] shallow.c: Don't free unallocated slabs

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 2, 2019, 06:01 UTC
Message-ID
<xmqqftkbfzy1.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191001150729.GI10875@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> ... This is really an internal implementation
> detail of how the slab code works. It would be nice if callers didn't
> have to care about it. Perhaps we ought to have a slab foreach()
> function that encapsulates this, which would let this caller do
> something like:
>
>   commit_depth_foreach(&depths, free_commit_depth);
>   commit_depth_clear(&depths);
>
> But since this is the only place that looks into the slab in this way,
> I'm happy to take your much simpler fix in the meantime.
Likewise.  Thanks, both.
Previous: Jeff King
Message 3 of 3 in “shallow.c: Don't free unallocated slabs”
  1. shallow.c: Don't free unallocated slabsAli Utku Selen, Sep 30, 2019
  2. Jeff KingOct 1, 2019
  3. Junio C HamanoOct 2, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.