Re: What's cooking in git.git (Jan 2020, #04; Wed, 22)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 23, 2020, 06:06 UTC
Message-ID: <xmqqftg6671g.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200122235333.GA6837@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 16 quoted lines

> On Wed, Jan 22, 2020 at 02:18:05PM -0800, Junio C Hamano wrote:
>> * yz/p4-py3 (2020-01-15) 14 commits
>>  - ci: also run linux-gcc pipeline with python3.5 environment
>
> I still think that this last patch needs to be reworked before this
> series is merged any further.
>
> The only Python script we have is 'git p4', so the Python version is
> only relevant for 'git p4' tests ('t98*'), while the rest of Git and
> the test suite couldn't care less [1].  This patch, however, not only
> builds Git and runs the full test suite for each of the two Python
> versions, but, worse, runs the full test suite _twice_ for each, first
> as a "regular" test run and then again with all the GIT_TEST_* knobs
> enabled.  Consequently, it adds ~50mins to every build's runtime.
>
> That's just too wasteful.

Thanks for a reminder. Yes, I do recall you raised the above point and I agree with the assessment.

What's the ideal endgame wrt the tests? Build with Py$N and run full test suite once, and run full test suite again with the unusual knobs enabled, which is what is done without this series, plus build with Py(5-$N) and run and run only t98?? tests?