Re: [PATCH v8 1/1] remote.c: fix handling of %(push:remoteref)

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2020, 22:21 UTC
Message-ID: <xmqqft7k0zkt.fsf@gitster.c.googlers.com>
In-Reply-To: <20200911214358.acl3hy2e763begoo@feanor>

Damien Robert <damien.olivier.robert@gmail.com> writes:

Show 12 quoted lines

> Hum, what about migrating the version that was in next to master? I am not
> fond of it because the series is not perfect and I am not satisfied with a
> patch series that is not as good as I would like it to be. So that was why
> I was arguing against merging it back then.
>
> On the other hand it does correct existing bugs, and the bugs it leaves
> remaining (apart from the memory leak) happens only in exotic cases. So I
> would not want my sense of perfection to prevent this series from graduating
> too long.
>
> And unfortunately I cannot give you an ETA for a fully satisfying series as
> I envision it.

That's OK---that is what "no rush" means.

We can throw the one bug it fixes together with the "bugs it leaves" into the same category, i.e. happens only in narrow cases. We now know that you won't be actively working on the topic right now, perhaps others can pick up where you left off and perhaps you can help reviewing such a follow-up work ;-)

Thanks.