Re: [PATCH v2 0/1] teach format.useAutoBase "whenAble" option

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2020, 22:21 UTC
Message-ID: <xmqqft6xbn97.fsf@gitster.c.googlers.com>
In-Reply-To: <20201001214653.1609405-1-jacob.e.keller@intel.com>

Jacob Keller <jacob.e.keller@intel.com> writes:

Show 6 quoted lines

> From: Jacob Keller <jacob.keller@gmail.com>
>
> This is a v2 of [1] to address comments on the mailing list. Primarily the
> change is to remove the option for --base=if-able, since it is not as useful
> as the configuration option. If we think it is desirable, adding back a
> whenable or whenAble option is easy enough.

The simplification is a great thing to do, and I agree with the rationale you wrote ...

Show 6 quoted lines

>     +    This does mean that a user cannot request this optional base commit
>     +    generation from the command line. However, this is likely not too
>     +    valuable. If the user requests base information manually, they will be
>     +    immediately informed of the failure to acquire a suitable base commit.
>     +    This allows the user to make an informed choice about whether to
>     +    continue the format.

... which is sensible.

Thanks, will queue.