git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Pain points in Git's patch flow

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 16, 2021, 19:50 UTC
Message-ID
<xmqqfszqko0k.fsf@gitster.g>
In-Reply-To
<YHaIBvl6Mf7ztJB3@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
>  3. Do you think patchwork goes in a direction that is likely to help
>     with these?
So here is a real-life example.
Let's say somebody is looking at a "gentle ping" [*1*]

znh> The patch seems to have fallen into the crack. zhn> Jeff and Junio, willing to help?

How would we figure out what happened to the patch today without visiting patchwork would be:

 1. Visit the message at lore.kernel.org/git/ [*1*]
 2. Notice that it is a response to a message, and click the link to
    be taken to [*2*]
 3. Notice that nobody commented on the patch.
 4. Type "f:zhening ref-filter" to the search box and search, with
    suspicion that this was an updated version of something.
 5. Click one of them in the result [*3*]
 6. This time, we can tell that this seemed to have had two earlier
    iterations, and after reading the discussion through, the last
    one changed the course in a major way.  Not just a new helper
    introduced in the earlier rounds has gone away, but an existing
    helper got removed.
 7. All comments in the discussion for the earlier two rounds can be
    read as supporting the new direction the latest round takes.
 8. The fact remains that even if the direction has been endorsed
    (see 7. above) nobody took a look at the implementation for the
    latest round.
 9. Make the final verdict.

I use my newsreader to do pretty much the equivalent of the above without hitting https://lore.kernel.org/git/ but the above is written to use the web interface, in order to make it reproducible more easily by anybody on the list.

Now, how can patchwork improve the above reviewer experience, out of the box and possibly with new helpe rools around it?

I can see #3 would immediately become obvious, and I hope #4-#5 would become unnecessary.

Anything else?

At steps #6 and #7, there is human judgment involved that may not be automatable, but would there be some mechanism to make it easy to help these steps if the user visits patchwork (instead of staying in my newsreader or web interface to the lore archive)?

I am of course not expecting to automate step #9 ;-) It would be nice though.

Thanks.
[References]
*1* https://lore.kernel.org/git/CAOLTT8Tis5Yjg8UR0c-i0BnqiFQvLXvDgxUQJ-WcP6jjQPu9cQ@mail.gmail.com/
*2* https://lore.kernel.org/git/pull.928.git.1617975348494.gitgitgadget@gmail.com/
*3* https://lore.kernel.org/git/pull.927.v2.git.1617809209164.gitgitgadget@gmail.com/
Previous: Atharva RaykarNext: Junio C Hamano
Message 14 of 46 in “Pain points in Git's patch flow”
  1. Jonathan NiederApr 14, 2021
  2. Bagas SanjayaApr 14, 2021
  3. Junio C HamanoApr 14, 2021
  4. Junio C HamanoApr 14, 2021
  5. Denton LiuApr 15, 2021
  6. Junio C HamanoApr 15, 2021
  7. Son Luong NgocApr 15, 2021
  8. Eric WongApr 19, 2021
  9. Theodore Ts'oApr 19, 2021
  10. Ævar Arnfjörð BjarmasonApr 21, 2021
  11. Eric WongApr 28, 2021
  12. Eric WongApr 28, 2021
  13. Atharva RaykarApr 15, 2021
  14. Junio C HamanoApr 16, 2021
  15. Junio C HamanoApr 16, 2021
  16. ZheNing HuMay 2, 2021
  17. Sebastian SchuberthApr 18, 2021
  18. Ævar Arnfjörð BjarmasonApr 18, 2021
  19. Eric WongApr 19, 2021
  20. Sebastian SchuberthApr 19, 2021
  21. Sebastian SchuberthApr 19, 2021
  22. Ævar Arnfjörð BjarmasonApr 19, 2021
  23. Sebastian SchuberthApr 19, 2021
  24. Theodore Ts'oApr 19, 2021
  25. Sebastian SchuberthApr 20, 2021
  26. Theodore Ts'oApr 20, 2021
  27. Felipe ContrerasApr 30, 2021
  28. Ævar Arnfjörð BjarmasonApr 20, 2021
  29. Eric WongApr 19, 2021
  30. Sebastian SchuberthApr 19, 2021
  31. Konstantin RyabitsevApr 19, 2021
  32. dwh@linuxprogrammer.orgMay 8, 2021
  33. Konstantin RyabitsevApr 19, 2021
  34. Stephen SmithApr 19, 2021
  35. dwh@linuxprogrammer.orgMay 8, 2021
  36. Bagas SanjayaMay 8, 2021
  37. Felipe ContrerasApr 30, 2021
  38. Daniel AxtensApr 21, 2021
  39. brian m. carlsonApr 26, 2021
  40. Theodore Ts'oApr 26, 2021
  41. Ævar Arnfjörð BjarmasonApr 26, 2021
  42. Eric WongApr 28, 2021
  43. brian m. carlsonApr 28, 2021
  44. Felipe ContrerasApr 30, 2021
  45. Felipe ContrerasApr 30, 2021
  46. Felipe ContrerasApr 30, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.