Re: [PATCH] repo-settings: fix checking for fetch.negotiationAlgorithm=default

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 31, 2022, 16:57 UTC
Message-ID: <xmqqfsp3kfm0.fsf@gitster.g>
In-Reply-To: <CABPp-BEehHHbDi_muWHCaT1GvRmPbPiMmvB-2O9+0w2A+yEM0Q@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 12 quoted lines

>> I.e. =default should always be equivalent to not declaring that config
>> at all anywhere, and not drift to being a reference to some name that
>> happens to be "default", as in the GNOME case.
>
> No, we have the same problem as the Gnome case.  See this part of the
> documentation for fetch.negotiationAlgorithm:
>
> """
>     The default is "default" which instructs Git to use the
>     default algorithm that never skips commits (unless the server has
>     acknowledged it or one of its descendants).
> """

That looks more like one of the bugs introduced when skipping was turned on for the "experimental" folks. To fix this, without turning skipping into the default too hastily, there needs two and half things to happen:

 * Give a new name for the non-skipping algorithm, and describe the
   algorithm like the above.

 * Describe "default" is "non-skipping" but "feature.experimental"
   makes "skipping" the default.

 * Support "non-skipping" in the configuration parser, so that even
   when something else becomes the default, people can choose it.

I would think.