git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/4] bisect.c: remove unnecessary include

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 6, 2022, 16:41 UTC
Message-ID
<xmqqfsmqyxj5.fsf@gitster.g>
In-Reply-To
<220406.86a6cyfy4l.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 10 quoted lines
> On Tue, Apr 05 2022, Garrit Franke wrote:
>
>> Remove include "hash-lookup.h".
>
> Like your 3/4 it would be nice to have a "orphaned since xyz", or was it
> never used etc?
>
> In these cases unlike most such C changes the compiler isn't of much use
> for validation (we might be including this implicitly), so an
> explanation saying why is helpful.

Thanks for pointing it out. I found the lack of explanation in some but not all of the changes disturbing.

Previous: Ævar Arnfjörð Bjarmason
Message 12 of 12 in “bisect.c: remove unused includes”
  1. bisect.c: remove unused includesGarrit Franke, Mar 31, 2022
  2. Junio C HamanoMar 31, 2022
  3. using iwyu (include-what-you-use) to analyze includes (was: [PATCH] bisect.c: remove unused includes)Ævar Arnfjörð Bjarmason, Apr 1, 2022
  4. 0/4 various: use iwyu (include-what-you-use) to analyze includesGarrit Franke, Apr 5, 2022
  5. Ævar Arnfjörð BjarmasonApr 6, 2022
  6. 4/4 apply.c: remove unnecessary includeGarrit Franke, Apr 5, 2022
  7. 3/4 serve.c: remove unnecessary includeGarrit Franke, Apr 5, 2022
  8. 1/4 contrib: add iwyu scriptGarrit Franke, Apr 5, 2022
  9. Ævar Arnfjörð BjarmasonApr 6, 2022
  10. 2/4 bisect.c: remove unnecessary includeGarrit Franke, Apr 5, 2022
  11. Ævar Arnfjörð BjarmasonApr 6, 2022
  12. Junio C HamanoApr 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.