git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mergetool(vimdiff): allow paths to contain spaces again

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2022, 16:22 UTC
Message-ID
<xmqqfsj5dlt7.fsf@gitster.g>
In-Reply-To
<pull.1287.git.1657726969774.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> To fix this, let's not expand the variables containing the path
> parameters before passing them to the `eval` command, but let that
> command expand the variables instead.

Yup, that is exactly the right approach to fix this kind of breakage.

Thanks for a clear description of the problem and the solution.
Fernando?  Ack?
Previous: Johannes Schindelin via GitGitGadgetNext: Fernando Ramos
Message 2 of 13 in “mergetool(vimdiff): allow paths to contain spaces again”
  1. mergetool(vimdiff): allow paths to contain spaces againJohannes Schindelin via GitGitGadget, Jul 13, 2022
  2. Junio C HamanoJul 13, 2022
  3. Fernando RamosJul 13, 2022
  4. Junio C HamanoJul 13, 2022
  5. Junio C HamanoJul 13, 2022
  6. Fernando RamosJul 13, 2022
  7. Junio C HamanoJul 13, 2022
  8. Junio C HamanoJul 13, 2022
  9. Fernando RamosJul 13, 2022
  10. Fernando RamosJul 13, 2022
  11. Junio C HamanoJul 13, 2022
  12. mergetool(vimdiff): allow paths to contain spaces againJohannes Schindelin via GitGitGadget, Jul 14, 2022
  13. Junio C HamanoJul 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.