git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Supporting `git add -a <exclude submodules>`

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 28, 2023, 18:24 UTC
Message-ID
<xmqqfs2yjgvr.fsf@gitster.g>
In-Reply-To
<xmqqsf6yjhhm.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
> By the way, I am surprised that "diff.ignoreSubmodules=all" is
> abused by anybody that way.  It depends on the implementation detail
> that we internally use the diff machinery to find which paths are
> not modified, and I would even say it is a BUG that "commit -a" pays
> attention to the configuration variable that way.  I would recommend
> strongly to stay away from that approach or your tools will get
> broken when the bug gets fixed.

Sorry, but I take this part back. This is an explicitly documented feature of the variable, so users and scripts alike should be able to depend on. It still feels like a layering violation, but it is too late to "fix" it now.

Previous: Junio C Hamano
Message 4 of 4 in “Supporting `git add -a <exclude submodules>`”
  1. Joanna WangSep 28, 2023
  2. Junio C HamanoSep 28, 2023
  3. Junio C HamanoSep 28, 2023
  4. Junio C HamanoSep 28, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.