Re: [PATCH 1/4] add-patch: Fix type missmatch rom msvc

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 27, 2024, 16:42 UTC
Message-ID: <xmqqfrm9t6up.fsf@gitster.g>
In-Reply-To: <965ac9bd-7340-4dbd-88da-2daa88c126c4@freenet.de>

Sören Krecker <soekkle@freenet.de> writes:

> If I understand your comments correctly, it would be preferably to
> switch to a data type like uint32_t or uint64_t so that the behavior
> is consisted on all platforms?

I personally wouldn't prefer that.

I'd rather stick to some "natural" platform type like ulong. I see no strong need to say "we must behave identically on all platforms" in this area. It is preferrable to have every platform use the most natural type on it, and make sure that we validate input that is too large to fit on each platform correctly (i.e. it is OK to diagnose "too big a line number" and die on 32-bit platform with much smaller line number than on 64-bit platform).

Thanks.