git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] [GSOC] Use unsigned type for bit flags in commit-reach.c

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 12, 2025, 21:16 UTC
Message-ID
<xmqqfrkiuan3.fsf@gitster.g>
In-Reply-To
<20250212192841.8321-1-dhar61595@gmail.com>
Moumita <dhar61595@gmail.com> writes:
> The `flags` variable holds multiple bitwise flags (PARENT1,
> PARENT2, STALE),these flags are defined using (1u << N), so maybe
> there will be no issues if it is changed from `int` to `unsigned
> int`

"This change will not break" is not a good reason to make the change, though, as not making that change will not break anything, either.

If you need to write something, say something that positively justifies the change, explaining readers why it is a good thing to do, and how the resulting code is _better_ than the original.

Thanks.
Previous: Moumita
Message 3 of 3 in “[GSOC] Use unsigned type for bit flags in commit-reach.c”
  1. 0/1 [GSOC] Use unsigned type for bit flags in commit-reach.cMoumita, Feb 12, 2025
  2. 1/1 commit-reach: use unsigned int for flags in paint_down_to_common()Moumita, Feb 12, 2025
  3. Junio C HamanoFeb 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.