Re: [PATCH 0/2] contrib/subtree: Add -S/--gpg-sign option

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2025, 23:15 UTC
Message-ID: <xmqqfrgnhuuw.fsf@gitster.g>
In-Reply-To: <20250528130116.21534-1-patrik@pspdfkit.com>

Patrik Weiskircher <patrik@pspdfkit.com> writes:

Show 8 quoted lines

> Hi!
>
> We use git subtree a lot to manage our dependencies, but recently started
> requiring signed commits. This patch adds support for signing commits to
> git subtree.
>
> This is my first submission to the Git project - you don't have to be gentle,
> but please let me know if I can improve anything.

A few things ;-) starting from the log message where you didn't quite add why we would want to do these changes.

Also, I think these two should be combined into a single patch. We add a feature and make sure the feature works correctly and we also make sure that the feature does not misfire when the user does not ask it to trigger, all in the same commit.