Re: [PATCH] send-email: don't duplicate Reply-to: in intro message

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2025, 14:05 UTC
Message-ID: <xmqqfrcli38p.fsf@gitster.g>
In-Reply-To: <175809074627.1696783.67425889158412786@noble.neil.brown.name>

NeilBrown <neilb@ownmail.net> writes:

Show 11 quoted lines

> Add parsing to the loop in pre_process_file() to recognise a Reply-to
> header and to store the result in $reply_to.  This means that the
> intro message will not get a second header and also means that
> any changes made to the Reply-To header during editing will be
> incorporated in the $reply_to variable and so included in all the
> generated email messages.
>
> Signed-off-by: NeilBrown <neil@brown.name>
> ---
>  git-send-email.perl | 3 +++
>  1 file changed, 3 insertions(+)

Makes sense.

Just FYI for any future contributions, it is customary to mark the second iteration as [PATCH v2] on the subject and to make the message a direct reply (with "Reply-To") to the previous iteration, to help people find how the patch evolved in the list archives like https://lore.kernel.org/git/

Obviously no need to redo this patch only for that, but if you need some other changes, sending v3 as a reply to the message I am responding to would be a good thing to do.

Thanks.

Show 15 quoted lines

>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 437f8ac46a85..e2248c223119 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1931,6 +1931,9 @@ sub pre_process_file {
>  					$in_reply_to = $1;
>  				}
>  			}
> +			elsif (/^Reply-To: (.*)/i) {
> +				$reply_to = $1;
> +			}
>  			elsif (/^References: (.*)/i) {
>  				if (!$initial_in_reply_to || $thread) {
>  					$references = $1;