Re: [PATCH] t1300: use test helpers instead of shell primitives

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2026, 02:39 UTC
Message-ID: <xmqqfr8mp0cx.fsf@gitster.g>
In-Reply-To: <20260102062029.18210-1-pushkarkumarsingh1970@gmail.com>

pushkarkumarsingh1970@gmail.com writes:

Show 6 quoted lines

> From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
>
> Replace plain "test -f" checks with "test_path_is_file" and symbolic
> link checks with "test_path_is_symlink". The test framework helpers
> provide clearer diagnostics and better consistency across the test
> suite.

The "test" is often implemented as a built-in utility in a shell, but not necessarily so. Either way, it is not correct to call it "shell primitive", as unlike "if", "for", it is not.