git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] shallow: set borders which are all reachable after clone shallow since

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 20, 2026, 20:59 UTC
Message-ID
<xmqqfr80xanx.fsf@gitster.g>
In-Reply-To
<xmqqh5ujuekq.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 20 quoted lines
>> ...
>> The modified implementation of a generic shallow boundary finder
>> based on rev-list ensures that all shallow border commits are reachable
>> also after being grafted. This is achieved by inspecting all parents
>> of each initial border commit candidate. The border commit candidate
>> is set border only when all its parents wern't on the initial list of
>> candidates. Otherwise the border commit candidate is not set as border
>> however its parents that weren't on the list of candidates are set as
>> borders.
>
> It is a minor point, but there are "boundary" and "border" used more
> or less interchangeably in the proposed commit log message, and
> would make the readers wonder if there are differences (I do not
> think we use the word "border" anywhere in our documentation).  It
> is minor as we do not have such mixture in the end-user facing part
> of the documentation with this patch.
>
> I'll let those (cc'ed) who may be more familiar with, or, at least
> have more code than I have in, the shallow infrastructure to comment
> on the way the updated code uses the revision machinery.

After this exchange, the topic has been dormant for almost full two months. As I do not deal with shallow clones myself, even though I understand that some folks rely on it working, I'd really prefer to see somebody who are familiar with the underlying logic to review this patch if we were to move forward with it.

Thanks.
Previous: Junio C HamanoNext: Samo Pogačnik
Message 5 of 10 in “Fixed --shallow-since generating descendant borders”
  1. Fixed --shallow-since generating descendant bordersSamo Pogačnik via GitGitGadget, Nov 22, 2025
  2. Junio C HamanoNov 22, 2025
  3. shallow: set borders which are all reachable after clone shallow sinceSamo Pogačnik via GitGitGadget, Nov 23, 2025
  4. Junio C HamanoNov 25, 2025
  5. Junio C HamanoJan 20, 2026
  6. Samo PogačnikJan 28, 2026
  7. Samo PogačnikFeb 7, 2026
  8. Junio C HamanoFeb 7, 2026
  9. Samo PogačnikMar 7, 2026
  10. shallow: ensure all boundary commits are reachable with --shallow-sinceSamo Pogačnik via GitGitGadget, Jan 31, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.