git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/mktree: remove USE_THE_REPOSITORY_VARIABLE

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 12, 2026, 19:58 UTC
Message-ID
<xmqqfr64es5o.fsf@gitster.g>
In-Reply-To
<2c9861c0-fdac-4123-8cd9-4a841755abf3@malon.dev>
Tian Yuchen <cat@malon.dev> writes:
Show 13 quoted lines
>> As somebody (Phillip?) said earlier, we probably should update
>> document and clearly say that removing USE_THE_REPOSITORY_VARIABLE
>> is not a high-value target when done in the builtin/ directory, even
>> though it is very desirable thing to do for more library-ish part of
>> the codebase.
>
> I am fully aware of this, and I did not specifically modify 
> the_repository in builtin/ during previous patches. It's just that this 
> macro makes me particularly uncomfortable, and I believe it would be 
> better to remove it.
>
> On the other hand, this patch is indeed boring and useless. Feel free to 
> ignore it.

Nah, I think we do want to keep it; once it is written, it is a waste to discard it, especially given that the change is not wrong per-se. If anything else, having it will save somebody else time and effort to do the same thing again ;-).

Thanks.
Previous: Tian Yuchen
Message 4 of 4 in “builtin/mktree: remove USE_THE_REPOSITORY_VARIABLE”
  1. builtin/mktree: remove USE_THE_REPOSITORY_VARIABLETian Yuchen, Mar 12, 2026
  2. Junio C HamanoMar 12, 2026
  3. Tian YuchenMar 12, 2026
  4. Junio C HamanoMar 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.