Re: [Question] check_repository_format_gently() is not side-effect-free

Tian Yuchen <cat@malon.dev> writes:

The verb "check" does not imply side-effect-free. By checking, each of these functions tries to achieve something, and the way the result of their work is conveyed back to the caller may not necessarily be only by their return values.

The adverb "gently" in this codebase typically means "the variant without gently signals problems by dying. Instead of dying, return to the caller with error code, so that the caller can decide to die".