Re: [PATCH v2 0/6] Support hashing objects larger than 4GB on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 16, 2026, 16:09 UTC
- Message-ID
- <xmqqfr2m4gd1.fsf@gitster.g>
- In-Reply-To
- <pull.2138.v2.git.1781621398.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Changes since v1: > > * Rebased to current master to resolve the conflicts with > ps/odb-source-loose
Very much appreciated.
> * Dropped the !LONG_IS_64BIT prereq from the added/touched tests, as it is > now no longer needed
Good thing to do and see that the code works as well as it could, whether a long is 32-bit or 64-bit ;-).
Show 18 quoted lines
> Philip Oakley (6): > hash-object: demonstrate a >4GB/LLP64 problem > object-file.c: use size_t for header lengths > hash algorithms: use size_t for section lengths > hash-object --stdin: verify that it works with >4GB/LLP64 > hash-object: add another >4GB/LLP64 test case > hash-object: add a >4GB/LLP64 test case using filtered input > > object-file.c | 14 +++++++------- > object-file.h | 6 +++--- > odb/source-files.c | 2 +- > odb/source-inmemory.c | 2 +- > odb/source-loose.c | 4 ++-- > odb/source.h | 2 +- > sha1dc_git.c | 3 +-- > sha1dc_git.h | 2 +- > t/t1007-hash-object.sh | 39 +++++++++++++++++++++++++++++++++++++++ > 9 files changed, 56 insertions(+), 18 deletions(-)
Will queue. Thanks.
Show 12 quoted lines
> > > base-commit: 700432b2ba22603a0bcb71475c9c333d17c9b0d1 > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2138%2Fdscho%2FPhilipOakley%2Fhashliteral_t-v2 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2138/dscho/PhilipOakley/hashliteral_t-v2 > Pull-Request: https://github.com/gitgitgadget/git/pull/2138 > > Range-diff vs v1: > > 1: 84e1cd0aa0 = 1: 9c01bac407 hash-object: demonstrate a >4GB/LLP64 problem > 2: 809d83e46f ! 2: aa5859c14f object-file.c: use size_t for header lengths > @@ Commit message
By the way, how is range-diff driven via GGG? After applying these patches on the same base commit, my "git range-diff v1...v2" invocation punts on matching step 2 and I do not get a comparison like this unless I give --creation-factor=<large number> from the command line.