Re: [PATCH 4/4] doc: convert git-request-pull synopsis and options to new style
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 19, 2026, 23:47 UTC
- Message-ID
- <xmqqfr1eleyx.fsf@gitster.g>
- In-Reply-To
- <5b6e9bd3f3569cf9977d1cfd120a92756ec86b29.1784490878.git.gitgitgadget@gmail.com>
"Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 33 quoted lines
> @@ -54,11 +54,15 @@ the `v1.0` release, and want it to be integrated into the project. > First you push that change to your public repository for others to > see: > > - git push https://git.ko.xz/project master > +----- > +git push https://git.ko.xz/project master > +----- > > Then, you run this command: > > - git request-pull v1.0 https://git.ko.xz/project master > +------ > +git request-pull v1.0 https://git.ko.xz/project master > +------ > > which will produce a request to the upstream, summarizing the > changes between the `v1.0` release and your `master`, to pull it > @@ -67,11 +71,15 @@ from your public repository. > If you pushed your change to a branch whose name is different from > the one you have locally, e.g. > > - git push https://git.ko.xz/project master:for-linus > +----- > +git push https://git.ko.xz/project master:for-linus > +----- > > then you can ask that to be pulled with > > - git request-pull v1.0 https://git.ko.xz/project master:for-linus > +----- > +git request-pull v1.0 https://git.ko.xz/project master:for-linus > +-----
Is there a widely accepted guideline among AsciiDoc users governing how many dashes should delimit these blocks, other than "at least four, with the opening and closing counts matching"? If so, what is it? We see five, six, five, and five dashes in the proposed changes above, and in '[PATCH 1/4]' we saw nine. Even if varying counts are functionally equivalent, the inconsistency is a bit distracting.
Thanks.
[Footnote]
* an excerpt from [PATCH 1/4]
diff --git a/Documentation/git-imap-send.adoc b/Documentation/git-imap-send.adoc index 538b91afc0..dd1e0a3718 100644 --- a/Documentation/git-imap-send.adoc +++ b/Documentation/git-imap-send.adoc @@ -192,7 +192,10 @@ supports only `XOAUTH2` as the mechanism. Once the commits are ready to be sent, run the following command: - $ git format-patch --cover-letter -M --stdout origin/master | git imap-send + +--------- +$ git format-patch --cover-letter -M --stdout origin/master | git imap-send +---------