Re: [PATCH 4/4] worktree add: let worktree_basename() return string copy

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2026, 18:56 UTC
Message-ID: <xmqqfqzuw23a.fsf@gitster.g>
In-Reply-To: <xmqqjypdj6g4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

>>> So going back to the confusing part of the log message,
>>> 
>>>     Remind ... to worktree_basename_dup().  Among the three callers
>>>     of worktree_basename(), two immediately make copies of the
>>>     returned string before using and freeing it, which makes for an
>>>     easy conversion.  Convert the other one from resetting ...
>>> 
>>> or something like that, perhaps?
>>
>> Yes.
>
> Thanks.  We do not know if other parts of the series gets more
> serious reviews that necessitates an updated version, so in the
> meantime I'll reword what I have locally.

And nothing happened since then. As the topic was in a good shape except for the confusing part of the log, which we amended in my tree already, let's mark the topic for 'next'.