Re: [PATCH] doc: remote-helpers: option pushcert if-asked
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 2, 2026, 09:01 UTC
- Message-ID
- <xmqqfqxjmwte.fsf@gitster.g>
- In-Reply-To
- <20260829183659.29947-1-lorenz.leutgeb@posteo.eu>
Lorenz Leutgeb <lorenz.leutgeb@posteo.eu> writes:
Show 6 quoted lines
> The documentation mentions that the value for the option "pushcert" is > "true" or "false". This is incomplete, as can be seen by analyzing > transport-helper.c:1009-1018 (added in commit 30261094b1f7fdcba3b7a1) > which also implements setting the option to the value "if-asked". > > Add the third value to the documentation (added in commit b9299a2bb1).
Except for these commit references not using the --pretty=reference format, I think the above is good enough, and the patch contents is true enough.
That's not much of a review, but that needs to suffice for now.
Will mark the topic ready for 'next'.
Show 18 quoted lines
> Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@posteo.eu>
> ---
> Documentation/gitremote-helpers.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitremote-helpers.adoc b/Documentation/gitremote-helpers.adoc
> index 39cdece16e..10921e91b9 100644
> --- a/Documentation/gitremote-helpers.adoc
> +++ b/Documentation/gitremote-helpers.adoc
> @@ -523,7 +523,7 @@ set by Git if the remote helper has the 'option' capability.
> 'option update-shallow' {'true'|'false'}::
> Allow to extend .git/shallow if the new refs require it.
>
> -'option pushcert' {'true'|'false'}::
> +'option pushcert' {'true'|'false'|'if-asked'}::
> GPG sign pushes.
>
> 'option push-option' <string>::