git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC14][RFC] Is there any interest in adding a port of checkpatch.pl to contrib/?

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2014, 19:29 UTC
Message-ID
<xmqqeh1z8fv8.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAL0uuq0RWpWPa2TOk09xE9SjG0-Z=EAMG2iQ9Y0z_XMYvRsJ3g@mail.gmail.com>
Jacopo Notarstefano <jacopo.notarstefano@gmail.com> writes:
Show 6 quoted lines
> It seems to me that the topic of adding the checkpatch.pl script to
> Git's source tree has cropped up several times in the past, as
> recently as a couple of days ago: $gmane/243607.
>
> It should be noted that its usage for its sake has been discouraged by
> Junio Hamano in $gmane/205998.
I've never said any such thing.

I only said I am not enthused against a proposal to add a build target that runs checkpatch or equivalent over *all* existing code, which will invite needless churn (read again the part of the message you quoted before I say "I am not enthused").

It is a totally separate issue for submitters to make sure they do not introduce *new* problems, and use of "checkpatch --no-tree" could be one way to do so.

Previous: Junio C HamanoNext: Jacopo Notarstefano
Message 4 of 6 in “[GSoC14][RFC] Is there any interest in adding a port of checkpatch.pl to contrib/?”
  1. Jacopo NotarstefanoMar 18, 2014
  2. Eric SunshineMar 18, 2014
  3. Junio C HamanoMar 18, 2014
  4. Junio C HamanoMar 18, 2014
  5. Jacopo NotarstefanoMar 18, 2014
  6. demerphqMar 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.