Re: [PATCH] MSVC: allow using ExtUtils::MakeMaker
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 4, 2014, 18:57 UTC
- Message-ID
- <xmqqeh1cq5wo.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1396510443-29087-1-git-send-email-marat@slonopotamus.org>
Marat Radchenko <marat@slonopotamus.org> writes:
Show 7 quoted lines
> Drop NO_PERL_MAKEMAKER from config.mak.uname for the MSVC platform. > > MakeMaker is available on Windows Perl implementations and > installs modules to correct location, unlike NO_PERL_MAKEMAKER Makefile. > > Signed-off-by: Marat Radchenko <marat@slonopotamus.org> > ---
As nobody seems to object to this change (and I do not have an environment nor inclination to test MSVC builds myself), I'll apply this directly to 'master', hoping that doing so reasonably ahead of 2.0-rc0 would give people enough time to complain if needed.
Thanks.
Show 15 quoted lines
> config.mak.uname | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config.mak.uname b/config.mak.uname > index fc5616d..6db4193 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -338,7 +338,6 @@ ifeq ($(uname_S),Windows) > NO_MKSTEMPS = YesPlease > SNPRINTF_RETURNS_BOGUS = YesPlease > NO_SVN_TESTS = YesPlease > - NO_PERL_MAKEMAKER = YesPlease > RUNTIME_PREFIX = YesPlease > NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease > NO_NSEC = YesPlease