git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] remote-helpers: move out of contrib

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 21, 2014, 21:42 UTC
Message-ID
<xmqqeh0q8ilm.fsf@gitster.dls.corp.google.com>
In-Reply-To
<53558c7fbd4d4_604be1f30c30@nysa.notmuch>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 9 quoted lines
>> Does this change relate to the moving of main scripts, and if so
>> how?
>
> Yes.
>
> Before the scripts were not generated, the shebang was '/usr/bin/env python',
> that means if the user doesn't have 'python' but 'python2' git-remote-hg would
> fail, even if the user did PYTHON_PATH=python2, therefore the test scripts
> should fail too, and that's the reason 'python' is used in the test scripts.

Ahh, OK, I agree that is a sensible change, then. I would think that deserves to be explained in the proposed log message, though.

Previous: Felipe ContrerasNext: Max Horn
Message 6 of 17 in “remote-helpers: graduate”
  1. 0/3 remote-helpers: graduateFelipe Contreras, Apr 21, 2014
  2. 1/3 remote-helpers: squelch python import exceptionsFelipe Contreras, Apr 21, 2014
  3. 2/3 remote-helpers: move out of contribFelipe Contreras, Apr 21, 2014
  4. Junio C HamanoApr 21, 2014
  5. Felipe ContrerasApr 21, 2014
  6. Junio C HamanoApr 21, 2014
  7. Max HornApr 23, 2014
  8. Junio C HamanoApr 23, 2014
  9. Felipe ContrerasApr 23, 2014
  10. Junio C HamanoApr 23, 2014
  11. Junio C HamanoApr 23, 2014
  12. Felipe ContrerasApr 23, 2014
  13. Max HornApr 23, 2014
  14. Felipe ContrerasApr 24, 2014
  15. Max HornApr 25, 2014
  16. Felipe ContrerasApr 26, 2014
  17. 3/3 remote-helpers: move tests out of contribFelipe Contreras, Apr 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.