Re: [PATCH] init - Honour the global core.filemode setting

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2014, 17:07 UTC
Message-ID: <xmqqegupm69n.fsf@gitster.dls.corp.google.com>
In-Reply-To: <542ED4B8.40603@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 14 quoted lines

>> The first sentence says what happens, as it should.
>> 
>> But it is not directly clear what makes the executable bit differ
>> and when it is a useful thing to ignore the differences, so the
>> second sentence that says "This may be useful" does not give the
>> reader very much.
>> 
> Clearly a major improvement.
>
> Does this (still) include the original line
> "See linkgit:git-update-index[1]"
>
> which helps the user to add *.sh files "executable" to the index, even if
> core.filemode is false ?

Thanks for catching; I omitted the reference by accident.

Perhaps end that sentence like this instead?

	... may be necessary to set this variable to `false`, and
	maintain the executable bit with `git update-index --chmod`
	(see linkgit:git-update-index[1]).