Re: [PATCH] run-command: use void to declare that functions take no parameters

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2014, 17:32 UTC
Message-ID: <xmqqegt97idj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141111025415.GB21328@peff.net>

Jeff King <peff@peff.net> writes:

> I had always just assumed that -Wstrict-prototypes was part of -Wall,
> but it is not (nor even part of -Wextra!). Maybe it is time to add it to
> your integration-build flags. :)

Yup, I had -Wold-style-definition but not -Wstrict-prototypes in the mix. Thanks for spotting.

Show 18 quoted lines

>
> Looks like we also need this on top of hv/submodule-config (still in pu,
> so squashing is probably best):
>
> diff --git a/submodule-config.h b/submodule-config.h
> index 58afc83..9061e4e 100644
> --- a/submodule-config.h
> +++ b/submodule-config.h
> @@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1,
>  		const char *name);
>  const struct submodule *submodule_from_path(const unsigned char *commit_sha1,
>  		const char *path);
> -void submodule_free();
> +void submodule_free(void);
>  
>  #endif /* SUBMODULE_CONFIG_H */
>
> -Peff