Re: git error in tag ...: unterminated header

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2015, 17:32 UTC
Message-ID: <xmqqegkzzoaz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150625155128.C3E9738005C@gemini.denx.de>

Wolfgang Denk <wd@denx.de> writes:

Show 18 quoted lines

> it turns out that recent versions of git (i. e. git version 2.2.0 or
> later, resp. anything which includes commit 4d0d8975 "Make sure
> fsck_commit_buffer() does not run out of the buffer") throws errors on
> our git repository  git://git.denx.de/u-boot:
>
> -> git fsck --full
> Checking object directories: 100% (256/256), done.
> error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
> error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
> error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
> Checking objects: 100% (328644/328644), done.
> Checking connectivity: 325719, done.
>
> Apparently for some reason the tags  LABEL_2006_03_12_0025,
> LABEL_2006_04_18_1106, and LABEL_2006_05_19_1133 are missing newlines,
> which was undetected so far, but now is raised as an error.
>
> Question is: how can we fix that?

It could be that 4d0d8975 is buggy and barking at a non breakage.

If there is no message in the tag, i.e.

    -- 8< --
    object 84ef51a632063e8cb57b2e9a4252497512831ffe
    type commit
    tag LABEL_2006_03_12_0025
    tagger Wolfgang Denk <wd@pollux.denx.de> 1142119613 +0100
    -- >8 --

I do not offhand see why we want to require that there is a lone blank line at the end.

Dscho?  What do you think?