git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 23, 2015, 16:38 UTC
Message-ID
<xmqqegjyrfrq.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAHGBnuM5TG6m7Rwd-EZTUXnaDNYomidthmCamCevNECTQCTnmA@mail.gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> writes:
> Well, from a user's perspective it does not matter which part of the
> internal implementation of diff-tree is responsible for printing that
> single line,...

That is not "internal implementation", but "logically separate parts". View it more like "'git show -s' does squelch the diff part but does not squelch the log output". After all, a single commit form of 'diff-tree' is a degenerate use case of feeding a single commit to 'diff-tree --stdin' from its standard input, which is a rough plumbing-level equivalent of 'show'.

Documenting the behaviour correctly is the best thing you could do at this point, as this is one of the oldest part of the system that existing scripts would rely on.

Previous: Sebastian SchuberthNext: Junio C Hamano
Message 6 of 14 in “diff-tree: do not show the sha1 of the given head with --quiet”
  1. diff-tree: do not show the sha1 of the given head with --quietSebastian Schuberth, Jul 22, 2015
  2. Johannes SchindelinJul 22, 2015
  3. diff-tree: do not show the sha1 of the given head with --quietSebastian Schuberth, Jul 22, 2015
  4. Junio C HamanoJul 22, 2015
  5. Sebastian SchuberthJul 23, 2015
  6. Junio C HamanoJul 23, 2015
  7. Junio C HamanoJul 23, 2015
  8. Sebastian SchuberthJul 23, 2015
  9. Jeff KingJul 23, 2015
  10. Junio C HamanoJul 23, 2015
  11. Sebastian SchuberthJul 23, 2015
  12. Junio C HamanoJul 23, 2015
  13. Sebastian SchuberthJul 23, 2015
  14. Jeff KingJul 24, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.