Re: [PATCH] describe: make '--always' fallback work after '--exact-match' failed

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2015, 18:39 UTC
Message-ID: <xmqqegix7qjk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1440072823-18024-1-git-send-email-szeder@ira.uka.de>

SZEDER Gábor <szeder@ira.uka.de> writes:

Show 14 quoted lines

> 'git describe [...] --always' should always show the unique abbreviated
> object name as a fallback when the given commit cannot be described with
> the given set of options, see da2478dbb0 (describe --always: fall back
> to showing an abbreviated object name, 2008-03-02).
>
> However, this is not the case when the combination '--exact-match
> --always' is given and the commit cannot be described, because in such
> cases 'git describe' errors out, as if '--always' were not given at all.
>
> Respect '--always' and print the unique abbreviated object name instead
> of erroring out when the commit cannot be described with '--exact-match
> --always'.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>

Well, that can be argued both ways. Your patch introduces a regression, as "--exact-match" is an instruction to error out when no tag exactly matches, and you deliberately break that.

My knee-jerk reaction is that the most sensible way forward is to make --exact-match and --always mutually incompatible.