Re: [PATCH v11 1/4] test-parse-options: print quiet as integer

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2016, 18:19 UTC
Message-ID: <xmqqegaqo6gg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <01020153cd2340f8-4665cd5f-cd5c-41ab-a162-20acc43ca52e-000000@eu-west-1.amazonses.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

Show 5 quoted lines

> Current implementation of parse-options.c treats OPT__QUIET() as integer
> and not boolean and thus it is more appropriate to print it as integer
> to avoid confusion.
>
> While at it, fix some style issues.

I counted the changes in t0040 and you have _more_ style fixes than the real change. That is not "while at it".

While I welcome the style fix, it is better done as a preparatory clean-up step before the real change.

> ---

Missing sign-off.

> -cat > typo.err << EOF
> +cat >typo.err <<EOF
>  error: did you mean \`--boolean\` (with two dashes ?)
>  EOF

If your "style cleanup" patch were separate, you could fix this (and other that have backslash escape inside the here-document) further to something like this:

	cat >type.err <<\EOF
	error: did you mean `--boolean` (with two dashes ?)
        EOF

Thanks.