Re: [PATCH v2 2/2] completion: checkout: complete paths when ref given

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2017, 22:45 UTC
Message-ID: <xmqqefz075or.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <9be8b988-f5b3-7365-ae7f-b46888253f4c@tngtech.com>

Cornelius Weig <cornelius.weig@tngtech.com> writes:

Show 7 quoted lines

> Hmm.. I'm a bit reluctant to let go of this just yet, because it was my
> original motivation for the whole patch. I admit that it may be
> confusing to not get completion in your example. However, I think that
> once acquainted with the new behavior, a user who wants some files
> cleaned would start by having a look at the list of files from "git
> checkout HEAD <TAB><TAB>". That's probably faster than spelling the
> first few characters and hit <TAB> for a file that's already clean.

I understand that "git checkout HEAD frotz<TAB>" that gives 47 other paths that all begin with "foo", when "frotz27" is the only one among them that you know you changed, is not very useful to narrow things down.

But it is equally irritating when you know "frotz27" is the only path that begins with "frotz" (after all, that is why you decided to stop typing after saying "frotz" and letting the comletion kick in) but you are not certain if you touched it. The completion being silent may be an indication that it is not modified, OR it may be an indication that you mistyped the leading part "frotz", and leaves you wondering.