Re: checkout -b remotes/origin/<branch> should not work

From: Junio C Hamano <gitster@pobox.com>
Date: May 14, 2017, 08:00 UTC
Message-ID: <xmqqefvr50m3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170514040048.evwtngo6bixtrput@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> I think this problem extends beyond "remotes/". The worst is:
>
>   git checkout -b HEAD
>
> but there are many confusing variants:
>
>   git checkout -b refs/heads/foo
>   git checkout -b tags/v1.0
>
> etc. Those are all perfectly legal names, but almost certainly not what
> the user intended. I think the plumbing should continue to allow them,
> but I wouldn't object to some common-sense think-o protections in the
> "checkout -b" plumbing (especially if it could be disabled for power
> users).

Yup. I suspect that the last one has uses (for those who may want to build on v1.0 tag it is conceivable that a local branch they use for it is named like so), but I agree that anything that begins with refs/* is not something any sane person would want to use.

sanity.branchname configuration or something that tells "checkout" and "branch" Porcelain commands to barf on an attempt to create such refnames does not sound too bad, and making it on by default may not even be a bad idea. But that leads me to say it may not even need to be a configurable thing (people who DO want funny names can already and still use the plumbing).

In any case, no command after such a change should forbid checking out such a funny-named branch if it already exists. We should complain only on (an attempted) creation.