Re: [PATCH] sub-process: refactor handshake to common function

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 26, 2017, 18:14 UTC
Message-ID: <xmqqeft3rrpy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <EB54F0E5-E555-40BF-8AA7-7CB3174FE22C@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 5 quoted lines

> Please note that I've recently refactored the capabilities negotiation a bit:
> https://github.com/git/git/commit/1514c8edd62d96006cd1de31e906ed5798dd4681
>
> This change is still cooking in `next`. I am not sure how this should/could
> be handled but maybe you can use my refactoring as your base?

I think they can play well together as independent topics. The known_caps[] thing you introduced essentially is the same as the struct subprocess_capability capablities[] Jonathan has.

Please check

    $ git show "pu^{/jt/subprocess-handshake' into pu}" convert.c

to see if it makes sense.

Thanks.