Re: [PATCH] completion: complete remote names too

From: Junio C Hamano <gitster@pobox.com>
Date: May 30, 2018, 03:49 UTC
Message-ID: <xmqqefhtera4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180525104842.2930-1-l.stelmach@samsung.com>

Łukasz Stelmach <l.stelmach@samsung.com> writes:

Show 6 quoted lines

> "git remote update" accepts both groups and single remotes.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Soliciting comments from usual suspects around this area...

Thanks.

Show 13 quoted lines

> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 961a0ed76..fb05bb2f9 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2632,7 +2632,7 @@ _git_remote ()
>  		__gitcomp_builtin remote_update
>  		;;
>  	update,*)
> -		__gitcomp "$(__git_get_config_variables "remotes")"
> +		__gitcomp "$(__git_remotes) $(__git_get_config_variables "remotes")"
>  		;;
>  	set-url,--*)
>  		__gitcomp_builtin remote_set-url