Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 25, 2018, 20:32 UTC
- Message-ID
- <xmqqeffrukd6.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAPig+cS-haNwJha44gncB9PrXRPcEPuqDVGLgKii29h=abq6sA@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 11 quoted lines
> I did consider other approaches, such as a more generic option. For
> example, --embed=range-diff:<prev>. I also considered supporting more
> complex use-cases. For instance, git-range-diff itself accepts the two
> ranges in several formats ("a..b c..d" or "x...z" or "i j k"), plus
> the creation-factor can be tweaked, so I weighed ways of incorporating
> all that detail into the single argument to --range-diff.
>
> However, those are all difficult to use (onerous to type and remember)
> and difficult to document. Thus, I opted for simplicity of individual,
> straight-forward options (--interdiff, --range-diff,
> --creation-factor), which are easy to type, remember, and document.Yes, that matches my conclusion that it is OK to have these on separate options that can grow as many meta-diff formats we would support.