Re: Segfault in master due to 4fbcca4eff

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2018, 15:55 UTC
Message-ID: <xmqqefdmyhe9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <5e7e6519-21c1-daff-65a5-7d2ca5e1dbd4@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 21 quoted lines

> On 9/21/2018 10:40 AM, Ævar Arnfjörð Bjarmason wrote:
>> On Fri, Sep 21 2018, Derrick Stolee wrote:
>>
>>>
>>> This error was reported by Peff [1] and fixed in [2], but as stated
>>> [3] I was waiting for more review before sending a v3. I'll send that
>>> v3 shortly, responding to the feedback so far.
>>>
>>> -Stolee
>>>
>>> [1]
>>> https://public-inbox.org/git/0bf9103c-9377-506b-7ad7-e5273d8e94fc@gmail.com/T/#u
>>>
>>> [2] https://public-inbox.org/git/pull.39.git.gitgitgadget@gmail.com/
>>>
>>> [3]
>>> https://public-inbox.org/git/8d6061de-1654-577c-40c6-211dbd03aa36@gmail.com/
>> Thanks and sorry for the duplicate report. I can confirm that applying
>> the v2 of that fixes the segfault for the test case I posted.
>
> Thanks for the report! You are a good dogfooder.

Thanks, both of you ;-). I was aware of the issue and proposed fix but forgot about it when merging things down to 'master'. Sorry about that.